[PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

[Felipe Balbi]

Hi,

On Thu, Feb 14, 2013 at 07:30:26PM +0100, Sascha Hauer wrote:
> > > > yeah, this is why I said we should ignore dr_mode (or bail out) when
> > > > !OTG.
> > > 
> > > Ok, that's what the patch effectively does. We have this in chipidea/core.c:
> > > 
> > > | 	dr_mode = ci->platdata->dr_mode;
> > > | 	if (dr_mode == USB_DR_MODE_UNKNOWN)
> > > | 		dr_mode = USB_DR_MODE_OTG;
> > > 
> > > default to otg if nothing specified.
> > 
> > you missed my point. I wanted something like:
> > 
> > dr_mode = ci->platdata->dr_mode;
> > if ((dr_mode == USB_DR_MODE_UNKNOWN) || !IS_ENABLED(CONFIG_USB_CHIPIDEA_OTG)
> > 	dr_mode = USB_DR_MODE_OTG;
> 
> So everytime the chipidea driver cannot do OTG the driver falls back to
> exactly this mode?

hehe, that was me being stupid I meant something like:

if (!IS_ENABLED(HOST) && dr_mode == HOST)

or

if (!IS_ENABLED(GADGET) && dr_mode == GADGET)

in those cases, it's best to either force OTG (then driver will work
with whatever it has) or bail out.

Thinking a bit harder, it's best to bail as you can't be sure udc.c or
host.c have been compiled in.

> > this copes with the situation where dr_mode == USB_DR_MODE_HOST but
> > kernel is gadget-only.
> 
> When I specify dr_mode = USB_DR_MODE_HOST in the devicetree indicating
> that my board is only host capable I exactly want the driver to be in
> host mode for this device, or to bail out if the kernel does not have
> host support compiled in.

right.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130214/73f94c12/attachment.sig>