[PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver

Mark Brown broonie at kernel.org
Tue Dec 24 08:51:27 EST 2013


On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>

I've applied this, however there is one small issue which I seem to have
forgotten to point out previously:

> +	/* Finally register devices */
> +	for (i = 0; i < pdata->num_regulators; i++) {

The driver should register all regulators regardless of how many are
used in the system in order to aid diagnostics.  Please send an
incremental patch to fix this.



More information about the linux-arm-kernel mailing list