[PATCH 2/3] ARM: shmobile: kzm9g: add FSI support for DTS

Simon Horman horms at verge.net.au
Tue Dec 24 00:54:34 EST 2013


On Mon, Dec 23, 2013 at 06:10:09PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 23-12-2013 17:21, Sergei Shtylyov wrote:
> 
> >>From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> >>This patch support FSI-AK4648 with simple audio card
> 
> >>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> >>Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> >>---
> >>  arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 33
> >>++++++++++++++++++++++++++++
> >>  1 file changed, 33 insertions(+)
> 
> >>diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> >>b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> >>index 5bb593d..eb8886b 100644
> >>--- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> >>+++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> >[...]
> >>@@ -226,6 +240,12 @@
> >>              };
> >>          };
> >>      };
> >>+
> >>+    ak4648: ak4648 at 0x12 {
> 
> >    Perhaps "sound-codec" or "audio-codec" would be a better name; hardware
> >specific names are not recommended by ePAPR. And drop "0x" from the address
> >part please.
> 
>    Sorry, I didn't notice the patch is posted as a part of pull
> request; I've probably missed the original posting (though I've
> already told to Morimoto-san that names like "ak4648" shouldn't be
> used).

Indeed, I think that you have commended on node naming on more
than one occasion. Feel free to make some cleanup patches if you
have the inclination.



More information about the linux-arm-kernel mailing list