[PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs

[Chen-Yu Tsai]

On Tue, Dec 24, 2013 at 12:44 AM, Emilio López <emilio at elopez.com.ar> wrote:
> Hi,
>
> El 23/12/13 05:37, Chen-Yu Tsai escribió:
>
>> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
>> ---
>
>
> Other than the lack of a commit description, the patch looks ok to me.

I'll try to add something meaningful. Might be the same as patch 3 for pinctrl
though.

>
>
>>   arch/arm/boot/dts/sun7i-a20.dtsi | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
>> b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 6ad5507..d6e7251 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -414,6 +414,20 @@
>>                                 allwinner,drive = <0>;
>>                                 allwinner,pull = <0>;
>>                         };
>> +
>> +                       clk_out_a_pins: clk_out_a {
>
>
> I see the other nodes all start like
>
>         foo_pins_a: foo0 at 0 {
>
> Maybe yours should too? Maxime, thoughts?

I suppose this makes sense if we wanted multiple pinctrl states
for the same device?

>
>
>> +                               allwinner,pins = "PI12";
>> +                               allwinner,function = "clk_out_a";
>> +                               allwinner,drive = <0>;
>> +                               allwinner,pull = <0>;
>> +                       };
>> +
>> +                       clk_out_b_pins: clk_out_b {
>> +                               allwinner,pins = "PI13";
>> +                               allwinner,function = "clk_out_b";
>> +                               allwinner,drive = <0>;
>> +                               allwinner,pull = <0>;
>> +                       };
>>                 };
>>
>>                 timer at 01c20c00 {
>>
>
> Thanks for working on this!
>
> Emilio