[PATCH 1/3] ARM: hisi: rename hi3xxx to hisi

Kevin Hilman khilman at linaro.org
Fri Dec 20 12:36:00 EST 2013


Olof Johansson <olof at lixom.net> writes:

> On Thu, Dec 19, 2013 at 6:52 PM, Haojian Zhuang
> <haojian.zhuang at linaro.org> wrote:
>> Since some new Hisilicon SoCs are not named as hi3xxx, rename mach-hi3xxx
>> to mach-hisi instead. And the pronounciation of "hisi" is similar to the
>> chinese pronounciation of Hisilicon. So Hisilicon guys like this name.
>>
>> ARCH_HI3xxx will be renamed later since other drivers are using it and
>> they are still in linux-next git tree. So rename ARCH_HI3xxx later.
>>
>
> Are you kidding me? We JUST merge your platform after a very painful
> review with many fumbly cycles, and the very first thing you do is
> rename it?
>
> I even complained about the crazy numbering and naming, and you didn't
> fix it while we were in review, and now just days after we merge the
> patches this one comes out?
>
> For now, we'll drop your original branch and fold in these patches
> with the original ones. There's no point in checking in a platform
> just to rename it, so we'll do the fixups.

Agreed. I've dropped the hi3xxx/soc branch from next/soc and rebuild
for-next without it.

Kevin





More information about the linux-arm-kernel mailing list