[PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Sachin Kamat sachin.kamat at linaro.org
Thu Dec 19 10:35:09 EST 2013


Hi Tomasz,

On 19 December 2013 19:40, Tomasz Figa <t.figa at samsung.com> wrote:
> Hi Sachin, Andrew,
>
> On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
>> Hi Tomasz,
>>
>> On 10 November 2013 22:38, Tomasz Figa <tomasz.figa at gmail.com> wrote:
>> > Hi Sachin, Andrew,
>> >
>> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> >> From: Andrew Bresticker <abrestic at chromium.org>
>> >>
>> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> >> Fix this so that the MFC will start up.
>> >
>> > Wow, this means that there is a mistake in the documentation. Not that
>> > I'm surprised, though.
>> >
>> > I guess you are sure about this, so:
>> >
>> > Reviewed-by: Tomasz Figa <t.figa at samsung.com>
>>
>> I believe you are going to take this through your tree along with a
>> few others which you have already reviewed?
>
> This patch seems to depend on my Exynos 5250 clock clean-up series, which
> will be merged for 3.14. Are you okay with this patch being merged for
> 3.14 as well or this fix is needed for earlier kernel versions too?
> (It is not a regression introduced in 3.13, though.)

Yes, I did rebase it on top of your series along with other patches.
Though not a regression introduced in 3.13, I think it makes sense to have this
sent as a fix during this release (3.13) itself. Let me know if you
want me to base it
on top of 3.13-rc4 and re-send.


-- 
With warm regards,
Sachin



More information about the linux-arm-kernel mailing list