[PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY

Simon Horman horms at verge.net.au
Mon Dec 16 19:31:07 EST 2013


On Tue, Dec 17, 2013 at 02:31:35AM +0300, Sergei Shtylyov wrote:
> On 12/16/2013 04:25 PM, I wrote:
> 
> >>The koelsch board uses has an SH ethernet controller which uses a Micrel
> >>phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the
> >>Micrel-specific phy driver rather than relying on the generic phy driver.
> 
> >    Frankly speaking, I'm seeing no advantages to doing that.
> 
>    Although wait, Geert has reported the absence of Rx FIFO overflow
> messages with this PHY driver, IIRC.
> 
> >>Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> 
> >    Analogous changes are needed for BOCK-W and Lager boards since they all
> >use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the
> >PHY IRQ patches but since no IRQ is generated still, this got delayed...
> 
>    Only I was going to do it via defconfigs...

That was my initial approach too. However I have been convinced
that Kconfig is a better way forwards.



More information about the linux-arm-kernel mailing list