[PATCH 4/6] arm64: lib: Implement optimized memcmp routine

Will Deacon will.deacon at arm.com
Mon Dec 16 11:56:48 EST 2013


On Wed, Dec 11, 2013 at 06:24:40AM +0000, zhichang.yuan at linaro.org wrote:
> From: "zhichang.yuan" <zhichang.yuan at linaro.org>
> 
> This patch, based on Linaro's Cortex Strings library, adds
> an assembly optimized memcmp() function.

[...]

> +#ifndef	__ARM64EB__
> +	rev	diff, diff
> +	rev	data1, data1
> +	rev	data2, data2
> +#endif

Given that I can't see you defining __ARM64EB__, I'd take a guess at you
never having tested this code on a big-endian machine.

Please can you fix that?

Will



More information about the linux-arm-kernel mailing list