[PATCH] pci: designware: fix missing msi irqs

Mohit KUMAR DCG Mohit.KUMAR at st.com
Mon Dec 16 01:48:46 EST 2013


> -----Original Message-----
> From: Jingoo Han [mailto:jg1.han at samsung.com]
> Sent: Monday, December 16, 2013 6:24 AM
> To: 'Harro Haan'; Mohit KUMAR DCG
> Cc: 'Bjorn Helgaas'; 'Marek Vasut'; 'Richard Zhu'; 'Shawn Guo'; Pratyush
> ANAND; 'Tim Harvey'; 'Juergen Beisert'; 'Arnd Bergmann'; 'Siva Reddy
> Kallam'; 'Srikanth T Shivanand'; 'Sean Cross'; linux-pci at vger.kernel.org; linux-
> arm-kernel at lists.infradead.org; 'Jingoo Han'
> Subject: Re: [PATCH] pci: designware: fix missing msi irqs
> 
> On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
> >
> > The interrupts were cleared after the irq handler was called.
> > This means that new interrupts that occur after the handler handled
> > the previous irq but before the interrupt is cleared will be missed.
> >
> > Signed-off-by: Harro Haan <hrhaan at gmail.com>
> > Cc: Mohit Kumar <mohit.kumar at st.com>
> > Cc: Jingoo Han <jg1.han at samsung.com>
> > Cc: Bjorn Helgaas <bhelgaas at google.com>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Richard Zhu <hong-xing.zhu at freescale.com>
> > Cc: Shawn Guo <shawn.guo at linaro.org>
> > Cc: Pratyush Anand <pratyush.anand at st.com>
> > Cc: Tim Harvey <tharvey at gateworks.com>
> > Cc: Juergen Beisert <jbe at pengutronix.de>
> > Cc: Arnd Bergmann <arnd at arndb.de>
> > Cc: Siva Reddy Kallam <siva.kallam at samsung.com>
> > Cc: Srikanth T Shivanand <ts.srikanth at samsung.com>
> > Cc: Sean Cross <xobs at kosagi.com>
> > Cc: linux-pci at vger.kernel.org
> > Cc: linux-arm-kernel at lists.infradead.org
> 
> Acked-by: Jingoo Han <jg1.han at samsung.com>
> 
> I was not able to reproduce the problem, however it looks good. Also, there
> is no side effect on Exynos platform.
> 
> Mohit,
> If you have some comments, please let us know.

- Quickly tested on SPEAr1310, working fine without any side effect. So is,
Acked-by: Mohit Kumar <mohit.kumar at st.com>
..
> 
> > ---
> >  drivers/pci/host/pcie-designware.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)




More information about the linux-arm-kernel mailing list