[PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver

Arnd Bergmann arnd at arndb.de
Sat Dec 14 07:31:39 EST 2013


On Saturday 14 December 2013, Alexander Shiyan wrote:
> On Sat, 7 Dec 2013 17:14:25 +0100
> Arnd Bergmann <arnd at arndb.de> wrote:
> 
> > On Saturday 07 December 2013, Alexander Shiyan wrote:
> > > > > +void __init clps711x_intc_init(phys_addr_t base, resource_size_t size)
> > > > > +{
> > > > > +   BUG_ON(_clps711x_intc_init(NULL, base, size));
> > > > > +}
> > > > > +EXPORT_SYMBOL(clps711x_intc_init);
> > > > 
> > > > No need to export this symbol, because you don't call the function from
> > > > loadable modules.
> > > 
> > > OK. I will remove it in the next version by adding "maybe_unused" to this
> > > function to avoid possible warnings.
> > 
> > The __maybe_unused should not be needed, as the function will still have
> > global scope.
> 
> Arnd can you merge this series with manual EXPORT_SYMBOL removal? Resend?

I'm still traveling at the moment and will only be resuming my normal arm-soc
work in January. All arm-soc patches are handled by Olof and Kevin still,
and irqchip patches go through Thomas anyway (or can get merged through arm-soc
with his Ack in case of dependencies).

	Arnd



More information about the linux-arm-kernel mailing list