[PATCH v6 03/15] usb: phy-mxs: Add auto clock and power setting

Peter Chen hzpeterchen at gmail.com
Fri Dec 13 00:55:25 EST 2013


On Fri, Dec 13, 2013 at 12:23 PM, Felipe Balbi <balbi at ti.com> wrote:
> On Fri, Dec 13, 2013 at 09:23:33AM +0800, Peter Chen wrote:
>> With the auto setting, the PHY's clock and power can be
>> recovered correctly from low power mode, it is ganranteed by IC logic.
>
> s/ganranteed/guaranteed
>

Will change.

> Also, I think you need to be slightly more verbose here. Maybe explain a
> bit what is the "auto setting". From what I can see from the code, it's
> a way to let HW manage clock gating.
>

Yes, you are right. This feature is used to open related power and clocks
automatically after receiving wakeup signal. I will add more explanation.

> Another question, does this feature work in all SoCs where this IP is
> available ?
>

Yes, these auto bits are existed from the 1st generation mxs-phy.

-- 
BR,
Peter Chen



More information about the linux-arm-kernel mailing list