[PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers

Bjorn Andersson bjorn.andersson at sonymobile.com
Thu Dec 12 22:58:46 EST 2013


On Thu 12 Dec 11:02 PST 2013, Linus Walleij wrote:

> On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd <sboyd at codeaurora.org> wrote:
> 
> > We should be writing bits here but instead we're writing the
> > numbers that correspond to the bits we want to write. Fix it by
> > wrapping the numbers in the BIT() macro. This fixes gpios acting
> > as interrupts.
> >
> > Signed-off-by: Stephen Boyd <sboyd at codeaurora.org>
> 
> I've applied this for fixes and tagged for stable.
> Björn, Rohit: OK?

This looks good.

JFYI; the pinctrl-msm is written with gpio-msm-v2 in mind as well, so replacing
it with pinctrl is on my todo list...

Regards,
Bjorn



More information about the linux-arm-kernel mailing list