[PATCH v4 1/2] usb: dwc3: Add Keystone specific glue layer

[Felipe Balbi]

Hi,

On Thu, Dec 12, 2013 at 12:25:29PM -0500, WingMan Kwok wrote:
> +static int kdwc3_remove(struct platform_device *pdev)
> +{
> +	struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
> +
> +	kdwc3_disable_irqs(kdwc);
> +	clk_disable_unprepare(kdwc->clk);

isn't this same clock feeding dwc3 core ?

> +	device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);

if it is, you should disable the clock only *after* removing the core,
provided core will access registers during remove.


-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/3302c8f3/attachment.sig>