[PATCH v3 2/2] usb: phy: Add keystone usb phy driver

[Kwok, WingMan]

> -----Original Message-----
> From: Shilimkar, Santosh
> Sent: Tuesday, December 10, 2013 10:15 AM
> To: Balbi, Felipe
> Cc: Kwok, WingMan; linux-usb at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; Greg Kroah-Hartman
> Subject: Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver
> 
> On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote:
> > Hi,
> >
> > On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote:
> >> +	ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy);
> >> +	if (ret)
> >> +		return ret;
> >> +	k_phy->usb_phy_gen.phy.init = keystone_usbphy_init;
> >> +	k_phy->usb_phy_gen.phy.shutdown = keystone_usbphy_shutdown;
> >
> > this *must* be initialized before adding the PHY to the subsystem. So
> > these two lines must be moved before usb_add_phy_dev().
> >
> Make sense. Probably its good idea to repost the $subject patch with above
> as well as other delay related comment.

Thanks.  I have updated my patch accordingly.  Please note that the same issue
exists on drivers/usb/phy/phy-am335x.c also.  If you want, I can send a fix for that.

Regards
WingMan