[PATCH] phy: omap_usb2: fix module dependency
Kishon Vijay Abraham I
kishon at ti.com
Wed Dec 11 00:44:45 EST 2013
On Wednesday 11 December 2013 01:54 AM, Felipe Balbi wrote:
> Due to over-use of select statements, we could
> fall into a situation where CONFIG_USB_PHY would
> be enabled while CONFIG_USB_SUPPORT wouldn't.
> This would generate a situation where usb_bind_phy()
> would not be defined and kernel build for some
> OMAP2PLUS platforms would fail.
> Fix this by replacing a 'select' with a more proper
> 'depends on'.
last week I sent a patch changing it to depends on USB_PHY and Greg has merged
it yesterday so it should come in -rc4. Do you think this patch will also be
> Reported-by: Russell King <rmk+kernel at arm.linux.org.uk>
> Signed-off-by: Felipe Balbi <balbi at ti.com>
> drivers/phy/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index a344f3d..d8b1a9a 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO
> config OMAP_USB2
> tristate "OMAP USB2 PHY Driver"
> depends on ARCH_OMAP2PLUS
> + depends on OMAP_CONTROL_USB
> select GENERIC_PHY
> select USB_PHY
> - select OMAP_CONTROL_USB
> Enable this to support the transceiver that is part of SOC. This
> driver takes care of all the PHY functionality apart from comparator.
More information about the linux-arm-kernel