[PATCH] phy: omap_usb2: fix module dependency

Felipe Balbi balbi at ti.com
Tue Dec 10 15:24:57 EST 2013


Due to over-use of select statements, we could
fall into a situation where CONFIG_USB_PHY would
be enabled while CONFIG_USB_SUPPORT wouldn't.

This would generate a situation where usb_bind_phy()
would not be defined and kernel build for some
OMAP2PLUS platforms would fail.

Fix this by replacing a 'select' with a more proper
'depends on'.

Reported-by: Russell King <rmk+kernel at arm.linux.org.uk>
Signed-off-by: Felipe Balbi <balbi at ti.com>
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index a344f3d..d8b1a9a 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on OMAP_CONTROL_USB
 	select GENERIC_PHY
 	select USB_PHY
-	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
 	  driver takes care of all the PHY functionality apart from comparator.
-- 
1.8.4.GIT




More information about the linux-arm-kernel mailing list