[PATCH 0/6] mmc: sdhci: a few fixes on timeout and max_discard_to
Dong Aisheng
b29396 at freescale.com
Tue Dec 10 07:56:02 EST 2013
Patch 1~4 mainly fixes the issue that the max timeout counter for uSDHC is
1 << 28 rather than 1 << 27. 1~2 fix getting the max timeout counter
while 3~4 fix setting the max timeout.
Thus it introduces two new platform hook: get_max_timeout and set_timeout
for those platform which have different timeout setting.
This issue is firstly reported here by Ed Sutter:
http://www.spinics.net/lists/linux-mmc/msg23375.html
The root cause is the max_discard_to got from uSDHC is too small, only 677ms,
which cause the max_discard_bytes for eMMC is only 512, then the discard operation
of mkfs.ext3 for an eMMC card is too slow, just like dead.
With above patches, the issue can be fixed.
Patch 5~6 adds the capability to calcalute the max_discard_to dynamically
for SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK.
Originally the max_discard_to for a high speed sdhc card may be:
mmc1: new high speed SDHC card at address aaaa
mmc1: calculated max. discard sectors 49152 for timeout 1355 ms
After fix:
mmc1: new high speed SDHC card at address aaaa
mmc1: calculated max. discard sectors 712704 for timeout 5422 ms
It also improves the card discard performance a lot due to max_discard_sectors
increase a lot.
There's also discussion about remove max_discard_to limit here:
http://www.spinics.net/lists/linux-mmc/msg23395.html
But it does not help for uSDHC since we can observe data timeout
on a Toshiba SD3.0 cards if we do not disable data timeout interrupt.
Dong Aisheng (6):
mmc: sdhci: add platfrom get_max_timeout hook
mmc: sdhci-esdhc-imx: fix incorrect max_discard_to for uSDHC
mmc: sdhci: add platform set_timeout hook
mmc: sdhci-esdhc-imx: set the correct max timeout value for uSDHC
mmc: sdhci: calculate max_discard_to dynamically for
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK
mmc: sdhci-esdhc-imx: use actual_clock to calculate timeout
drivers/mmc/host/sdhci-esdhc-imx.c | 22 ++++++++++++++++++
drivers/mmc/host/sdhci.c | 43 +++++++++++++++++++++++++++++------
drivers/mmc/host/sdhci.h | 3 ++
3 files changed, 60 insertions(+), 8 deletions(-)
--
1.7.2.rc3
More information about the linux-arm-kernel
mailing list