[PATCH v3 5/5] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework

[Heiko Stübner]

Hi Tomasz,

Am Montag, 9. Dezember 2013, 18:19:16 schrieb Tomasz Figa:
> > diff --git a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c index f50454a..0a86953 100644
> > --- a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > +++ b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c

[...]

> > @@ -86,6 +50,5 @@ DT_MACHINE_START(S3C2416_DT, "Samsung S3C2416
> > (Flattened Device Tree)")
> > 
> >  	.map_io		= s3c2416_dt_map_io,
> >  	.init_irq	= irqchip_init,
> >  	.init_machine	= s3c2416_dt_machine_init,
> > 
> > -	 .init_time	= clocksource_of_init,
> 
> Should it really be a part of this patch?

Yes it is needed as part of the conversion, as somebody has to call 
of_clk_init(), which the init_time default-handler does.

The only other option would be to introduce a new local init_time callback, 
calling of_clk_init and clocksource_of_init, only to remove it again in an 
additional patch.


Heiko