[TRIVIAL PATCH 1/2] regulator: s5m8767: Define symbol for buck control mask

Sachin Kamat sachin.kamat at linaro.org
Tue Dec 10 04:18:38 EST 2013


Hi Krzysztof,

On 10 December 2013 14:39, Krzysztof Kozlowski <k.kozlowski at samsung.com> wrote:

>  static int s5m8767_reg_disable(struct regulator_dev *rdev)
>  {
>         struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev);
>         int ret, reg;
> -       int  mask = 0xc0, enable_ctrl;
> +       int mask = S5M8767_ENCTRL_MASK, enable_ctrl;

Couldn't we get rid of this mask variable here too?

Otherwise the patch looks good to me.

-- 
With warm regards,
Sachin



More information about the linux-arm-kernel mailing list