[PATCH 1/7] ARM: EXYNOS: initial board support for exynos5260 SoC

Sachin Kamat sachin.kamat at linaro.org
Mon Dec 9 01:23:01 EST 2013


Hi Rahul,

On 6 December 2013 21:26, Rahul Sharma <rahul.sharma at samsung.com> wrote:
> From: Pankaj Dubey <pankaj.dubey at samsung.com>
>
> This patch add basic arch side support for exynos5260 SoC.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey at samsung.com>
> Signed-off-by: Arun Kumar K <arun.kk at samsung.com>

Since you are posting the patch, your signed off is also required.

[snip]

>  void exynos4_restart(enum reboot_mode mode, const char *cmd)
>  {
>         __raw_writel(0x1, S5P_SWRESET);
> @@ -371,7 +387,8 @@ static void __init exynos4_map_io(void)
>  static void __init exynos5_map_io(void)
>  {
>         iotable_init(exynos5_iodesc, ARRAY_SIZE(exynos5_iodesc));
> -
> +       if (soc_is_exynos5260())
> +               iotable_init(exynos5260_iodesc, ARRAY_SIZE(exynos5260_iodesc));

Add this after 5250 to maintain numerical order.

>         if (soc_is_exynos5250())
>                 iotable_init(exynos5250_iodesc, ARRAY_SIZE(exynos5250_iodesc));
>  }

[snip]
>
>  #define S5P_VA_SYSRAM          S3C_ADDR(0x02400000)
>  #define S5P_VA_SYSRAM_NS       S3C_ADDR(0x02410000)
> +
Unnecessary blank line addition.


-- 
With warm regards,
Sachin



More information about the linux-arm-kernel mailing list