Re: [PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver

[Alexander Shiyan]

> On Saturday 07 December 2013, Alexander Shiyan wrote:
> > > > +void __init clps711x_intc_init(phys_addr_t base, resource_size_t size)
> > > > +{
> > > > +   BUG_ON(_clps711x_intc_init(NULL, base, size));
> > > > +}
> > > > +EXPORT_SYMBOL(clps711x_intc_init);
> > > 
> > > No need to export this symbol, because you don't call the function from
> > > loadable modules.
> > 
> > OK. I will remove it in the next version by adding "maybe_unused" to this
> > function to avoid possible warnings.
> 
> The __maybe_unused should not be needed, as the function will still have
> global scope.

OK. Then, if additional comments not appears, I will ask you to apply this
series and remove EXPORT() during the merge. I was remind of this in a week.

---