[PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver

Felipe Balbi balbi at ti.com
Fri Dec 6 15:46:29 EST 2013

On Fri, Dec 06, 2013 at 04:13:07PM +0200, Aaro Koskinen wrote:
> Add Tahvo USB transceiver driver.
> Based on old code from linux-omap tree. The original driver was written
> by Juha Yrjölä, Tony Lindgren, and Timo Teräs.
> Signed-off-by: Aaro Koskinen <aaro.koskinen at iki.fi>

compile error:

  CC [M]  drivers/usb/phy/phy-tahvo.o
drivers/usb/phy/phy-tahvo.c: In function ‘tahvo_usb_probe’:
drivers/usb/phy/phy-tahvo.c:371:2: error: too many arguments to function ‘extcon_dev_register’
  ret = extcon_dev_register(&tu->extcon, &pdev->dev);
In file included from drivers/usb/phy/phy-tahvo.c:26:0:
include/linux/extcon.h:186:12: note: declared here
 extern int extcon_dev_register(struct extcon_dev *edev);
make[1]: *** [drivers/usb/phy/phy-tahvo.o] Error 1
make: *** [drivers/usb/phy/] Error 2

fixed it up with:

diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index 7cf1766..8bb833e 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -368,7 +368,9 @@ static int tahvo_usb_probe(struct platform_device *pdev)
 	tu->extcon.name = DRIVER_NAME;
 	tu->extcon.supported_cable = tahvo_cable;
-	ret = extcon_dev_register(&tu->extcon, &pdev->dev);
+	tu->extcon.dev.parent = &pdev->dev;
+	ret = extcon_dev_register(&tu->extcon);
 	if (ret) {
 		dev_err(&pdev->dev, "could not register extcon device: %d\n",

please make sure it still works with v3.13-rc2 + this patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/328d1b3e/attachment.sig>

More information about the linux-arm-kernel mailing list