[PATCH] ARM: mcpm: remove redundant dsb instructions prior to sev

Will Deacon will.deacon at arm.com
Fri Dec 6 11:34:05 EST 2013


sync_cache_w already includes a dsb, so we can just use sev() directly
then following a cache-sync.

Cc: Dave Martin <Dave.Martin at arm.com>
Cc: Nicolas Pitre <nico at fluxnic.net>
Signed-off-by: Will Deacon <will.deacon at arm.com>
---

Hi guys,

I was auditing our uses of wfe (they're all fine) but noticed these
extra dsbs in the process.

Will

 arch/arm/common/mcpm_entry.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/common/mcpm_entry.c b/arch/arm/common/mcpm_entry.c
index 26020a03f659..74140ed9922f 100644
--- a/arch/arm/common/mcpm_entry.c
+++ b/arch/arm/common/mcpm_entry.c
@@ -167,7 +167,7 @@ void __mcpm_cpu_down(unsigned int cpu, unsigned int cluster)
 	dmb();
 	mcpm_sync.clusters[cluster].cpus[cpu].cpu = CPU_DOWN;
 	sync_cache_w(&mcpm_sync.clusters[cluster].cpus[cpu].cpu);
-	dsb_sev();
+	sev();
 }
 
 /*
@@ -183,7 +183,7 @@ void __mcpm_outbound_leave_critical(unsigned int cluster, int state)
 	dmb();
 	mcpm_sync.clusters[cluster].cluster = state;
 	sync_cache_w(&mcpm_sync.clusters[cluster].cluster);
-	dsb_sev();
+	sev();
 }
 
 /*
-- 
1.8.2.2




More information about the linux-arm-kernel mailing list