[PATCH v5 1/3] mfd: tps6586x: add version detection
Thierry Reding
thierry.reding at gmail.com
Fri Dec 6 09:26:05 EST 2013
On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
>
> Signed-off-by: Stefan Agner <stefan at agner.ch>
> ---
> Changes since v4:
> - Use variable named version instead of ret
>
> Changes since v2:
> - Avoid moving devm_kzalloc
> ---
> drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++-------
> include/linux/mfd/tps6586x.h | 7 +++++++
> 2 files changed, 49 insertions(+), 8 deletions(-)
I think I also already gave my Reviewed-by on both this and 2/3, neither
of which changed significantly enough to warrant that to be dropped. In
general it's fine to keep Reviewed-by and Acked-by as long as you're
only changing minor things.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/d8a623c3/attachment.sig>
More information about the linux-arm-kernel
mailing list