[PATCH] ARM: clean-up common multi-platform kconfig options

Rob Herring robherring2 at gmail.com
Thu Dec 5 16:34:17 EST 2013


On Thu, Dec 5, 2013 at 2:25 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 05 December 2013, Rob Herring wrote:
>> select ARM_AMBA
>> select ARM_GIC if CPU_V7
>> select HAVE_SMP if CPU_V7
>> select MIGHT_HAVE_CACHE_L2X0 if ARCH_MULTI_V6_V7
>> select ARCH_HAS_CPUFREQ
>> select ARCH_HAS_OPP
>
> Not sure about ARM_GIC and HAVE_SMP, as they won't typically be
> set on Cortex-A8, Scorpion and PJ4. The other suggestions sound
> good, and your patch looks fine as well.

HAVE_SMP only enables visibility of the SMP kconfig option. That could
cause randconfig builds that would not boot if SMP_ON_UP was not
enabled, but a "select SMP_ON_UP if SMP" here would fix that though.

GIC is on probably 90% of the v7 platforms, so seems like a small cost
to carry it. We've tried to avoid putting core specific knowledge into
the kernel, but effectively it is still there. It's just duplicated in
each platform selecting the individual options (GIC, SCU, TWD, errata,
etc.) rather than a core type.

Rob



More information about the linux-arm-kernel mailing list