[PATCH] ARM: Clean up setup printks a bit

Olof Johansson olof at lixom.net
Thu Dec 5 12:28:03 EST 2013


On Thu, Dec 5, 2013 at 1:14 AM, Emilio López <emilio at elopez.com.ar> wrote:
> Hi Olof,
>
> El 04/12/13 20:30, Olof Johansson escribió:
>
>> Clean up the setup ARM printks a bit. Add printk level to a few
>> that were missing (CPU: <...> ones, in particular), and switch from
>> printk(KERN_* ..) to pr_*().
>>
>> Finally, un-wrap some long lines since it makes it harder to grep the
>> sources from where an error came from and tweak some cases of indentation.
>>
>> Signed-off-by: Olof Johansson <olof at lixom.net>
>> ---
>>   arch/arm/kernel/setup.c |   39 +++++++++++++++++++--------------------
>>   1 file changed, 19 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
>> index 6a1b8a8..7c472f4 100644
>> --- a/arch/arm/kernel/setup.c
>> +++ b/arch/arm/kernel/setup.c
>
>
> ...
>
>
>>
>>         if (meminfo.nr_banks >= NR_BANKS) {
>> -               printk(KERN_CRIT "NR_BANKS too low, "
>> -                       "ignoring memory at 0x%08llx\n", (long
>> long)start);
>> +               pr_crit("NR_BANKS too low, "ignoring memory at
>> 0x%08llx\n",
>
>
> There's a stray " there

That's certainly embarrassing, and I can't explain how I got that to
past my build. Revised patch sent to the tracker.


-Olof



More information about the linux-arm-kernel mailing list