[PATCH V3] dma: tegra: register as an OF DMA controller

Arnd Bergmann arnd at arndb.de
Wed Dec 4 21:46:08 EST 2013


On Wednesday 04 December 2013, Stephen Warren wrote:
> > 
> > We really need to be better at having a common set of rules regarding what
> > it actually means to set the slave_id through dma_slave_config(). IMHO
> > we should just treat it as a bug for any dmaengine driver that is configured
> > through DT, or we should get rid of this entirely.
> 
> By the end of this series (for the Tegra driver) I can remove those "+"
> lines you quoted above; the slave ID will only come from DT through
> of_xlate, and any slave ID in the slave_config will simply be ignored.

Ok, that's certainly a step in the right direction. However, as I said
my comment wasn't really directed at you and I think it's more important
to have a clear policy that we can enforce across all dmaengine drivers.

It's really up to Vinod and Dan to decide how it should be handled
in general.

	Arnd



More information about the linux-arm-kernel mailing list