[PATCH] arm64: dts: Add a virtio disk to the RTSM motherboard

Mark Brown broonie at kernel.org
Tue Dec 3 14:51:18 EST 2013


On Tue, Dec 03, 2013 at 07:41:43PM +0000, Will Deacon wrote:
> On Tue, Dec 03, 2013 at 07:24:03PM +0000, Mark Brown wrote:

> > +			virtio_block at 0130000 {
> > +				compatible = "virtio,mmio";
> > +				reg = <0x130000 0x1000>;

> Can we make this 0x200 for the size? That's what kvmtool uses and, from the
> virtio-mmio spec, config data from offset 0x100+ is driver-specific. A quick
> look at the virtio block driver suggests we only use 31 bytes of that at the
> moment, so 4k is really OTT (and doesn't match the page size for 64K page
> systems anyway).

Sure, I'll send a patch to make this change for the foundation model
too.

> With that change:

>   Acked-by: Will Deacon <will.deacon at arm.com>

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131203/b2479a04/attachment-0001.sig>


More information about the linux-arm-kernel mailing list