[RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

Linus Walleij linus.walleij at linaro.org
Tue Dec 3 07:27:21 EST 2013

On Tue, Dec 3, 2013 at 12:15 PM, Hanjun Guo <hanjun.guo at linaro.org> wrote:

> +       /* if can't be initialised from DT, try ACPI way */
> +       if (!arch_timer_get_rate())
> +               arch_timer_acpi_init();
> +
>         arch_timer_rate = arch_timer_get_rate();

This looks a bit fragile. Having a call like arch_timer_get_rate()
to check whether there is a DT node for the timer doesn't seem
right, can you refactor the code to provide some
has_arch_timer_node() or similar call instead, so it's a bit easier
to understand & maintain at least?

Linus Walleij

More information about the linux-arm-kernel mailing list