Re: [PATCH 4/4] ARM: dts: i.MX27 boards: Switch to use standard GPIO and IRQ flags definitions

[Alexander Shiyan]

Hello.

> On Sat, Nov 30, 2013 at 10:18:04AM +0400, Alexander Shiyan wrote:
> > diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
> > index 3145bdb..2cb9e4b 100644
> > --- a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
> > +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
> > @@ -16,7 +16,8 @@
> >  
> >  &cspi1 {
> >  	fsl,spi-num-chipselects = <2>;
> > -	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
> > +	cs-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>,
> > +		   <&gpio4 27 GPIO_ACTIVE_LOW>;
> 
> Shouldn't it also be GPIO_ACTIVE_HIGH?

Value specified originally wrong. I corrected this value. However, the SPI driver
does not use the GPIO active value for GPIO-based chipselects, so this change safely.
Thanks.

---