[PATCH v3 1/2] dmaengine: add interface of dma_get_slave_channel

zhangfei gao zhangfei.gao at gmail.com
Tue Aug 20 03:58:41 EDT 2013


> No, this is not the right approach.
>
> When patch is applied and you find an issue you fix the issue. I have already
> pushed and merged this. So removing is a bad idea.
> you provide a fix for this miss.
>
> Also for this you need to give due credit to Dan (reporter). That is how the
> process works.
>
> Anyway I have applied the below fix and will push it out.
>
> ---
> dmaengine: fix - error: potential NULL dereference 'chan'
>
> commit 7bb587f4 "dmaengine: add interface of dma_get_slave_channel" introduced
> the above error so fix it
>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Suggested-by: Zhangfei Gao <zhangfei.gao at linaro.org>
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>

Thanks Vinod for the kind education.
Understand, will take care next time.

BTW, it is strange I do not see such compile warning here :(



More information about the linux-arm-kernel mailing list