[PATCH 01/20] mtd: pxa3xx-nand: replace pxa_request_dma with dmaengine

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Wed Aug 7 13:46:13 EDT 2013


Hi Daniel,

On Wed, Aug 07, 2013 at 05:33:50PM +0200, Daniel Mack wrote:
> From: Zhangfei Gao <zhangfei.gao at marvell.com>
> 
> [zonque at gmail.com: rebased in top of l2-mtd.git. The newly introduced
> ARCH_HAS_DMA hack was changed into a check for CONFIG_HAS_DMA]
> 

Are you sure you need to introduce the CONFIG_HAS_DMA ifdef?

The reason I introduced the ARCH_HAS_DMA macro was to avoid including
the "mach/dma.h" header. Now that you've removed it, I don't think
this driver can be used in any platform where CONFIG_HAS_DMA=n.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list