[PATCH 0/8] ARM: at91/dt: make use of periph id macros

Richard Genoud richard.genoud at gmail.com
Thu Aug 1 05:27:48 EDT 2013


2013/8/1 Richard Genoud <richard.genoud at gmail.com>:
> 2013/8/1 Boris BREZILLON <b.brezillon at overkiz.com>:
>> Hello,
>>
>> This patch series move at91 SoCs peripheral id definitions from machine
>> specific include dir to dt-bindings include dir.
>> These macros are used to reference interrupts instead of peripheral numbers.
>>
>> This makes dt definitions cleaner and easier to debug (one can easily tell if
>> the peripheral macro used to reference an interrupt line is not the good one).
>>
>> These macros will be used for clk definitions and references too.
>>
>> I am not sure 'include/dt-bindings/at91/xxx' is the best place to put these
>> definitions as there are no soc specific directories in dt-bindings include
>> dir right now. Maybe something like 'include/dt-bindings/soc/at91/xxx' or
>> 'include/dt-bindings/peripherals/at91/xxx' would be better.
>> What do you think ?
> Well, I'd rather use "atmel" than "at91" because, AFAIK, this prefix
> has been dropped for new atmel SoCs (sama5 for instance).

[changed Mark Brown address from opensource.wolfsonmicro.com to
kernel.org (the 1st one failed)]

The whole serie seems good to me (add adding the missing defines is great).

You can add my:
Reviewed-by: Richard Genoud <richard.genoud at gmail.com>
on the whole serie.

and my
Tested-by: Richard Genoud <richard.genoud at gmail.com>
on patch 7/8


Richard.



More information about the linux-arm-kernel mailing list