[RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS

[Philipp Zabel]

Hi Marek,

Am Mittwoch, den 24.04.2013, 02:31 +0200 schrieb Marek Vasut:
> Hi Philipp,
> 
> > Hi Marek,
> > 
> > Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
> > > Dear Fabio Estevam,
> > > 
> > > > Hi Marek,
> > > > 
> > > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex at denx.de> wrote:
> > > > > Without this, I get the following problem when building kernel:
> > > > > 
> > > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > > > 
> > > > > NOTE: I think this patch is almost absolutely not correct.
> > > > > 
> > > > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > > > Cc: Sascha Hauer <s.hauer at pengutronix.de>
> > > > > Cc: Philipp Zabel <p.zabel at pengutronix.de>
> > > > > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > > > 
> > > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > > is the one who takes patches into staging.
> > > 
> > > I'm not sure if the select is at correct symbol, I dont think it is.
> > 
> > OF_VIDEOMODE is the correct one. The implementation of
> > of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
> 
> I really need VIDEOMODE_HELPERS, not OF_VIDEOMODE. If I select only 
> OF_VIDEOMODE, I still get the issue above.
> 
> Check drivers/gpu/drm/drm_modes.c , it's protected by CONFIG_VIDEOMODE_HELPERS

Indeed, I was looking at the wrong checkout. Sorry for the noise.

regards
Philipp