[PATCH] ARM: ux500: Supply a DTS file for the u8540 platform

Linus Walleij linus.walleij at linaro.org
Tue Apr 23 06:58:52 EDT 2013


On Thu, Apr 4, 2013 at 9:29 AM, Lee Jones <lee.jones at linaro.org> wrote:

> This is a skeleton DTS file which only enables serial. Just using
> this simple file yields a terminal when booting u8540.
>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

Now, wait... this doesn't work.

> +/ {
> +  model = "ST-Ericsson U8540 platform with Device Tree";
> +  compatible = "st-ericsson,u8540";
> +
> +       memory {
> +              reg = <0x00000000 0x20000000>;
> +              };

Funny whitespace. Use tabs ...

> +       soc-u9500 {

Please rename this not just "soc"

> +                 uart at 80120000 {
> +                                       status = "okay";
> +                                              };
> +
> +               uart at 80121000 {
> +                               status = "okay";
> +                                      };
> +
> +               uart at 80007000 {
> +                               status = "okay";
> +                                      };
> +                                      };
> +};

The whitespace looks a bit funny compared to the
old patch, what happened here?

It also has the side effect that patch 5/9 does not
apply... By the way, since I already applied 4/9, please
squash 5/9 into this patch to avoid problems.

Finally, please patch arch/arm/boot/dts/Makefile
in the obvious way so that the DTB gets compiled.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list