[PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Fri Apr 19 07:44:46 EDT 2013


Hello.

On 19-04-2013 6:17, Simon Horman wrote:

>>>> +/* USB PHY */
>>>> +static struct resource usb_phy_resources[] = {
>>>> +	[0] = {
>>>> +		.start		= 0xffe70000,
>>>> +		.end		= 0xffe70900 - 1,
>>>> +		.flags		= IORESOURCE_MEM,
>>>> +	},
>>>> +	[1] = {
>>>> +		.start		= 0xfff70000,
>>>> +		.end		= 0xfff70900 - 1,
>>>> +		.flags		= IORESOURCE_MEM,
>>>> +	},

>>> Please consider using the macros for these initialisers.

>>     I'm just moving the code as is here. The destination file still
>> uses old style initializers, and probably needs the wholesale
>> conversion patch in the future.

> My preference is for you to either convert these users in this patch or
> provide a patch that makes a wholesale conversion.

    I'll try to do the latter but my load is currently very high, so that
may take some time.

WBR, Sergei




More information about the linux-arm-kernel mailing list