[PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

Simon Horman horms at verge.net.au
Thu Apr 18 22:17:55 EDT 2013


On Thu, Apr 18, 2013 at 09:40:43PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 18-04-2013 19:44, Russell King - ARM Linux wrote:
> 
> >>+/* USB PHY */
> >>+static struct resource usb_phy_resources[] = {
> >>+	[0] = {
> >>+		.start		= 0xffe70000,
> >>+		.end		= 0xffe70900 - 1,
> >>+		.flags		= IORESOURCE_MEM,
> >>+	},
> >>+	[1] = {
> >>+		.start		= 0xfff70000,
> >>+		.end		= 0xfff70900 - 1,
> >>+		.flags		= IORESOURCE_MEM,
> >>+	},
> 
> >Please consider using the macros for these initialisers.
> 
>    I'm just moving the code as is here. The destination file still
> uses old style initializers, and probably needs the wholesale
> conversion patch in the future.

My preference is for you to either convert these users in this patch or
provide a patch that makes a wholesale conversion.



More information about the linux-arm-kernel mailing list