[V3 patch 05/19] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu

Santosh Shilimkar santosh.shilimkar at ti.com
Thu Apr 18 04:38:12 EDT 2013


On Friday 12 April 2013 06:05 PM, Daniel Lezcano wrote:
> All the drivers are using, in their initialization function, the
> for_each_possible_cpu macro.
> 
> Using for_each_online_cpu means the driver must handle the initialization
> of the cpuidle device when a cpu is up which is not the case here.
> 
> Change the macro to for_each_possible_cpu as that fix the hotplug
> initialization and make the initialization routine consistent with the
> rest of the code in the different drivers.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
> ---
>  arch/arm/mach-ux500/cpuidle.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-ux500/cpuidle.c b/arch/arm/mach-ux500/cpuidle.c
> index c29c1bf..5657d4a 100644
> --- a/arch/arm/mach-ux500/cpuidle.c
> +++ b/arch/arm/mach-ux500/cpuidle.c
> @@ -125,7 +125,7 @@ int __init ux500_idle_init(void)
>  		return ret;
>  	}
>  
> -	for_each_online_cpu(cpu) {
> +	for_each_possible(cpu) {
There should no problem with online_cpu() usage
as well as long as one is not limmiting number of
boot CPUs using the max_cpus option.

But I agree making possible_cpu() would take care
of that case as well.

Regards,
Santosh




More information about the linux-arm-kernel mailing list