[PATCH 12/12] time/jiffies: bring back unconditional LATCH definition
john.stultz at linaro.org
Fri Sep 28 17:55:22 EDT 2012
On 09/28/2012 02:36 PM, Arnd Bergmann wrote:
> Patch a7ea3bbf5d "time/jiffies: Allow CLOCK_TICK_RATE to be undefined"
> breaks the compilation of targets that rely on the LATCH definition,
> because of recursive header file inclusion not defining CLOCK_TICK_RATE
> before it is checked here.
> This fixes the problem by moving LATCH back to where it was, but it
> seems that there are still cases where SHIFTED_HZ is defined incorrectly
> because of the same problem. Need to investigate further.
> Without this patch, building h7201_defconfig results in:
> arch/arm/mach-h720x/common.c: In function 'h720x_gettimeoffset':
> arch/arm/mach-h720x/common.c:50:73: error: 'LATCH' undeclared (first use in this function)
> arch/arm/mach-h720x/common.c:50:73: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm/mach-h720x/common.c:51:1: warning: control reaches end of non-void function [-Wreturn-type]
Hrrm. Ok. I had a patch for 3.7 that tried to get rid of the generic
CLOCK_TICK_RATE derived users, but that may not fly if there's still
LATCH users around. I guess I'll tweak it so we keep LATCH around,
probably by mering your change into my tree.
I suspect the long term fix is to push the LATCH definition up into arch
specific code that is using it, so it can be made dynamic instead of a
compile time constant. Otherwise it might be hard to get a unified
zImage working. But for now I guess your current fix is good short-term.
More information about the linux-arm-kernel