[PATCH v4 1/2] watchdog: at91sam9_wdt: add device tree support

[Fabio Porcedda]

On Thu, Sep 27, 2012 at 7:19 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
> On 16:59 Thu 27 Sep     , Fabio Porcedda wrote:
>> On Thu, Sep 27, 2012 at 7:56 AM, Jean-Christophe PLAGNIOL-VILLARD
>> <plagnioj at jcrosoft.com> wrote:
>> > On 12:25 Tue 25 Sep     , Fabio Porcedda wrote:
>> >> Tested on an at91sam9260 board (evk-pro3)
>> >>
>> >> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
>> >> ---
>> >>  .../devicetree/bindings/watchdog/atmel-wdt.txt      | 19 +++++++++++++++++++
>> >>  drivers/watchdog/at91sam9_wdt.c                     | 21 +++++++++++++++++++++
>> >>  2 files changed, 40 insertions(+)
>> >>  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>> >> new file mode 100644
>> >> index 0000000..5947929
>> >> --- /dev/null
>> >> +++ b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>> >> @@ -0,0 +1,19 @@
>> >> +* Atmel Watchdog Timers
>> >> +
>> >> +** at91sam9-wdt
>> >> +
>> >> +Required properties:
>> >> +- compatible: must be "atmel,at91sam9260-wdt".
>> >> +- reg: physical base address of the controller and length of memory mapped
>> >> +  region.
>> >> +
>> >> +Optional properties:
>> >> +- heartbeat: contains the watchdog heartbeats in seconds.
>> > more I read this binding more it's seems wrong
>> >
>> > Today we do not use yet the watchdog framework which we will so we need to
>> > use the same binding as the watchdog framework
>>
>> What is the binding of the heartbeat value in the watchdog framework?
>> I didn't found any binding of the heartbeat in other dt enabled drivers.
> when you read the new watchdog framework cf watchdog_dev.c and watchdog_core.c
>
> you will see that we can set a timeout which have the same meaning as
> heartbeat
>
> the key point here is you try to solve the DT the wrong way -> drivers
> specific
>
> the binding need to be framwork specific os here we need to do the binding of
> the watchdog framework first and then use it in the at91sam9 driver evenif we
> do not switch yet. Because in the DT we describe the hw not a drvier
> implementation

Ok i will try to send an updated patch following your advice.

> Best Regards,
> J.


Best regards
-- 
Fabio Porcedda