ARM: OMAP: fix new sparse warnings
grinberg at compulab.co.il
Thu Sep 27 09:38:32 EDT 2012
On 09/25/12 01:09, Paul Walmsley wrote:
> Commit e54adb1e79762d3591459e5b0e9b9ff578e33fdb ("ARM: OMAP: omap3evm:
> cleanup revision bits") adds a new sparse warning:
> arch/arm/mach-omap2/board-omap3evm.c:90:4: warning: symbol 'get_omap3_evm_rev' was not declared. Should it be static?
> This symbol no longer appears to be used outside this file, so mark it
> static and remove the export.
> Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> debug_card_init() function") results in the following new sparse
> arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
> Fix by including the proper header file.
> 1. https://sparse.wiki.kernel.org/index.php/Main_Page
Yeah, my compiler did not emit those... Thanks for the fix!
> Signed-off-by: Paul Walmsley <paul at pwsan.com>
> Cc: Igor Grinberg <grinberg at compulab.co.il>
> Cc: Tony Lindgren <tony at atomide.com>
Acked-by: Igor Grinberg <grinberg at compulab.co.il>
More information about the linux-arm-kernel