[PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

Linus Walleij linus.walleij at linaro.org
Wed Sep 26 10:13:56 EDT 2012

On Wed, Sep 26, 2012 at 4:08 PM, viresh kumar <viresh.kumar at linaro.org> wrote:
> On Wed, Sep 26, 2012 at 5:49 PM, Mark Brown
> <broonie at opensource.wolfsonmicro.com> wrote:
>> On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote:
>>> On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar
>>> > SPI functional clock must be disalble/enable in non RTPM suspend/resume
>>> > hooks. Currently it is only done for RTPM cases.
>>> > This patch add support to disable/enbale clock for conventional
>>> > suspend/resume calls.
>>> Cross dependency between runtime suspend/resume and
>>> common suspend/resume. Oh the horror ...
>> This should be fine, we runtime resume before we suspend.
> I believe Vipul sent this patch for the cases where RTPM in not
> enabled in the configs.

OK so we need to handle the cases where either, both or
just one of them is enabled...

Mark says the defined semantics is that runtime PM is
resumed across suspend/resume but I'd just like to
understand the overall mechanism that makes sure
this happens and I'm go...

However there is another problem with the patch,
because in -next there is also pin control handling
in the runtime hooks, so we need to duplicate
not only clocks but also that in each of the functions.

Maybe we can first make a patch that breaks out
resource handling so we can call that from each
of the suspend/resume calls? (I'll try.)

Linus Walleij

More information about the linux-arm-kernel mailing list