[PATCH] ARM: mx28: Skip OCOTP FEC MAC setup if in DT

Shawn Guo shawn.guo at linaro.org
Tue Sep 25 07:24:33 EDT 2012


On Tue, Sep 25, 2012 at 01:01:46PM +0200, Marek Vasut wrote:
> > >  		np = of_find_compatible_node(from, NULL, "fsl,imx28-fec");
> > >  		if (!np)
> > >  		
> > >  			return;
> > > 
> > > +
> > > +		if (of_get_property(np, "local-mac-address", NULL))
> > > +			continue;
> > > +
> > 
> > The block should be put after "from" assignment below.
> 
> Can you please elaborate why would that be necessary?
> 
Without assigning 'np' to 'from', the next iteration of 'for' loop
will still find the first fec node.  Then what's point of 'continue'?

Shawn



More information about the linux-arm-kernel mailing list