[PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Yegor Yefremov yegor_sub1 at visionsystems.de
Tue Sep 25 04:46:34 EDT 2012


On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists at googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
> 
> Okay, so the patch description says "This needs to be 12 on this platform".
> 
>>  config FORCE_MAX_ZONEORDER
>> -	int "Maximum zone order" if ARCH_SHMOBILE
>> -	range 11 64 if ARCH_SHMOBILE
>> +	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
>> +	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> 
> but you leave it up to the user to select something that may not be
> suitable.  Wouldn't _just_ adding:
> 
> 	default "12" if SOC_AM33XX
> 
> after the "range", and making no other changes be good enough and match
> what the patch description says?

You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?

Patch sent.

Yegor




More information about the linux-arm-kernel mailing list