[PATCH 1/2] arm: Add ARM ERRATA 775420 workaround
Catalin Marinas
catalin.marinas at arm.com
Fri Sep 21 04:29:16 EDT 2012
On Fri, Sep 21, 2012 at 02:04:04AM +0100, Simon Horman wrote:
> On Thu, Sep 20, 2012 at 10:58:53AM +0100, Catalin Marinas wrote:
> > On 12 September 2012 08:14, Simon Horman <horms at verge.net.au> wrote:
> > > +config ARM_ERRATA_775420
> > > + bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock"
> > > + depends on CPU_V7
> > > + help
> > > + This option enables the workaround for the 775420 Cortex-A9 (r2p2,
> > > + r2p6,r2p8,r2p10,r3p0) erratum. In case a date cache maintenance
> > > + operation aborts with MMU exception, it might cause the processor
> > > + deadlock. This workaround puts DSB before executing ISB at the
> > > + beginning of the abort exception handler.
> > > +
> > > endmenu
> >
> > The only case where we can get an abort on cache maintenance is
> > v7_coherent_user_range(). I don't think we have any ISB on the
> > exception handling path for this function, so we could just add the
> > DSB there:
>
> I think that an advantage of Abe-san's implementation is that
> it might to be a bit more robust. But your proposal is certainly
> much cleaner and for that reason I agree it is a good option.
It is more robust but I'm not sure it's worth putting a DSB a any data
abort.
> I've updated the patch, but since the code is now all yours
> I'm unsure if the author should be changed or not.
But the Kconfig entry is yours and it has more lines :)
Acked-by: Catalin Marinas <catalin.marinas at arm.com>
More information about the linux-arm-kernel
mailing list