[PATCH v2 2/2] ARM: at91: add at91sam9_wdt driver to at91sam9260

Fabio Porcedda fabio.porcedda at gmail.com
Thu Sep 20 03:52:39 EDT 2012


Hi Jean-Christophe,

On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
> On 13:57 Wed 19 Sep     , Fabio Porcedda wrote:
>> Tested on an at91sam9260 board (evk-pro3)
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
>> ---
>>  arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
>> index 66389c1..680b1c8 100644
>> --- a/arch/arm/boot/dts/at91sam9260.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
>> @@ -233,6 +233,12 @@
>>                                       trigger-external;
>>                               };
>>                       };
>> +
>> +                     watchdog at fffffd40 {
> disable dy default

All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default.
IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver,
they are safe to be enabled by default.
I'm missing something?

>> +                             compatible = "atmel,at91sam9-wdt";
>> +                             reg = <0xfffffd40 0x10>;
>> +                     };
>> +
>
> Best Regards,
> J.

Thanks for the review
-- 
Fabio Porcedda



More information about the linux-arm-kernel mailing list