[PATCH 3/3] ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages

Paul Walmsley paul at pwsan.com
Wed Sep 19 18:48:25 EDT 2012


Hi Benoît,

On Tue, 18 Sep 2012, Cousson, Benoit wrote:

> On 9/18/2012 4:12 PM, Paul Walmsley wrote:
> > The decision was made a few months ago to allow struct omap_hwmod
> > records and struct clk records to omit clockdomain information if the
> > clockdomain is not software-controllable.  See for example commit
> > 868c157df9721675c19729eed2c96bac6c3f1d01 ("ARM: OMAP2+: hwmod: remove
> > prm_clkdm, cm_clkdm; allow hwmods to have no clockdomain").
> > 
> > So convert an existing pr_warning() to a pr_debug() (regarding missing
> > clockdomains in clocks), and add a pr_debug() for missing hwmod
> > clockdomains.
> 
> At some point I sent you a small RFC to still keep the message if neither
> oh->clkdm nor oh->_clk->clkdm was there. I've never had the time to test it,
> but that should then cover OMAP2, 3 & 4 cases.

OK let's plan to test and add something like that during the 3.8 time 
frame... probably it should also depend on the value of clkdm_control.  
It's not clear to me exactly what that conditional should look like...


- Paul


More information about the linux-arm-kernel mailing list