[PATCH] serial: omap: Remove unnecessary checks from suspend/resume

Kevin Hilman khilman at deeprootsystems.com
Wed Sep 19 17:43:17 EDT 2012


"Poddar, Sourav" <sourav.poddar at ti.com> writes:

> Hi Felipe,
>
> On Tue, Sep 18, 2012 at 5:04 PM, Felipe Balbi <balbi at ti.com> wrote:
>> On Tue, Sep 18, 2012 at 05:05:54PM +0530, Sourav Poddar wrote:
>>> Drop the check for "up" being valid on suspend/resume callbacks.
>>> It should be valid always. Get rid of the "pdata" check also as
>>> serial_omap_get_context_loss_count() checks for it.
>>>
>>> Tested on omap4 panda and 3630 based Beagle board.
>>
>> you need a blank line here. Other than that:
>>
>> Reviewed-by: Felipe Balbi <balbi at ti.com>
>>
>> ps: what kind of tests did you run, btw ?
>>
> Boot tested on Panda.
> Boot and PM tested(hitiing Off) on Beagle.

What does "PM tested" mean.  hitting off in idle?  hitting off in
suspend?  both?

Please clarify.

Thanks,

Kevin



More information about the linux-arm-kernel mailing list