[RFT/PATCH] serial: omap: prevent resume if device is not suspended.
Paul Walmsley
paul at pwsan.com
Tue Sep 18 18:57:08 EDT 2012
On Tue, 18 Sep 2012, Felipe Balbi wrote:
> On Tue, Sep 18, 2012 at 06:10:50PM +0530, Sourav Poddar wrote:
> > Greg's tty-next is not booting on 2420 based N800. The failure is
> > observed at serial init itself. The reason might be that n800 tries to
> > resume even though it is not suspended before.
> >
> > Reported-by: Paul Walmsley <paul at pwsan.com>
> > Signed-off-by: Sourav Poddar <sourav.poddar at ti.com>
>
> FWIW:
>
> Reviewed-by: Felipe Balbi <balbi at ti.com>
>
> Paul does this fix the issue for you ? Note that it depends on a
> previous patch Sourav sent [1]
>
> [1] http://marc.info/?l=linux-omap&m=134796819607889&w=2
Yes, thanks - that fixes it,
Tested-by: Paul Walmsley <paul at pwsan.com>
> There's one thing that gets my attention, though, why only n800 would
> fail here ?
>
> I wonder if we should be using:
>
> pm_runtime_set_active(dev);
> pm_runtime_get_enable(dev);
>
> to prevent our runtime_resume() to be called from probe, but Sourav
> tested and it doesn't work on BeagleBoard, but it works on PandaBoard.
>
> Does it ring any bell ??
Nothing off the top of my head but haven't looked into it -- maybe this
rings a bell with Kevin?
- Paul
More information about the linux-arm-kernel
mailing list