[PATCH 27/34] media: mx2_camera: use managed functions to clean up code

javier Martin javier.martin at vista-silicon.com
Tue Sep 18 04:34:25 EDT 2012


Hi Shawn,

On 18 September 2012 09:43, Shawn Guo <shawn.guo at linaro.org> wrote:
> On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote:
>> This patch breaks the driver:
>>
> Javier,
>
> Can you please apply the following change to see if it fixes the
> problem?
>
> Shawn
>
> @@ -1783,6 +1783,8 @@ static int __devinit mx2_camera_probe(struct platform_device *pdev)
>                         goto exit;
>         }
>
> +       platform_set_drvdata(pdev, NULL);
> +
>         pcdev->soc_host.drv_name        = MX2_CAM_DRV_NAME,
>         pcdev->soc_host.ops             = &mx2_soc_camera_host_ops,
>         pcdev->soc_host.priv            = pcdev;

Yes. That fixes the problem.

With this fix:

Tested-by: Javier Martin <javier.martin at vista-silicon.com>

Regards.
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com



More information about the linux-arm-kernel mailing list